feat(config): allow to change the max length of the bulk string #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the proto's max length of bulk string is hard code to 512MiB, and it's impossible to create a string value more than that. And Redis allows to change this value by the configuration `proto-max-bulk-len`, so we also just add this to align the behavior.
torwig
approved these changes
Jul 24, 2024
PragmaTwice
reviewed
Jul 25, 2024
| # By default, the max length of bulk string is limited to 512MB. If you want to | ||
| # change this limit to a different value(must >= 1MiB), you can use the following configuration. | ||
| # | ||
| # proto-max-bulk-len 536870912 |
There was a problem hiding this comment.
Yes, I had thought about this. However the configuration's name didn't indicate the unit, so I think it will be better to use bytes.
There was a problem hiding this comment.
You can use ParseSizeAndUnit here, or you can rename it to proto-max-bulk-len-mb.
There was a problem hiding this comment.
Currently, the config rewrite will change it to the number of bytes. I have created an issue to support this: #2445, and we can disallow using unit as the suffix of the configuration.
|
ghost
approved these changes
Jul 25, 2024
PragmaTwice
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #2399.
Currently, the proto's max length of the bulk string is hard coded to 512MiB, and it's impossible to create a string value more than that. And Redis allows us to change this value by the configuration
proto-max-bulk-len, so we also just add this to align the behavior.