Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(hyperloglog): add go test cases and minor optimizations/bugfixes #2463

Merged
merged 3 commits into from
Aug 4, 2024
Merged

chore(hyperloglog): add go test cases and minor optimizations/bugfixes #2463

merged 3 commits into from
Aug 4, 2024

Conversation

mapleFU
Copy link
Member

@mapleFU mapleFU commented Aug 2, 2024 •
edited
Loading

  • Gocase testing

@mapleFU mapleFU mentioned this pull request Aug 2, 2024
Open
9 tasks
@PragmaTwice PragmaTwice changed the title chore: Gocase test and minor optimizations chore(hyperloglog): add go test cases and minor optimizations Aug 3, 2024
@mapleFU mapleFU marked this pull request as ready for review August 4, 2024 03:59
@mapleFU mapleFU changed the title chore(hyperloglog): add go test cases and minor optimizations chore(hyperloglog): add go test cases and minor optimizations/bugfixes Aug 4, 2024
@mapleFU
Copy link
Member Author

mapleFU commented Aug 4, 2024

@git-hulk @PragmaTwice this patch:

  1. Does some minor optimization in command implemention
  2. Fix the bug for Command impl
  3. Gocase testings

@mapleFU
Copy link
Member Author

mapleFU commented Aug 4, 2024

Thanks @PokIsemaine for telling me the bug in cmd here

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 4, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
59.9% Coverage on New Code
1.0% Duplication on New Code

See analysis details on SonarCloud

@PragmaTwice PragmaTwice merged commit f9d7297 into apache:unstable Aug 4, 2024
34 checks passed
@mapleFU mapleFU deleted the gocase-test-and-minor-opt branch August 4, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PragmaTwice PragmaTwice PragmaTwice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mapleFU @PragmaTwice