feat: add CLIENT PAUSE and CLIENT REPLY subcommands #2495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(command): add CLIENT REPLY subcommand
git-hulk
requested review from
git-hulk,
torwig and
PragmaTwice
and removed request for
git-hulk,
torwig and
PragmaTwice
git-hulk
reviewed
Aug 18, 2024
|
@furkan-bilgin Thanks for your contribution. Could you please help to pass the CI lint according to https://github.com/apache/kvrocks/actions/runs/10441248380/job/28912245323?pr=2495 |
|
|
@furkan-bilgin Looks good if you can add some Go test cases to cover this. And another point is that we should disable the |
PragmaTwice
reviewed
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of #2422
I have added two subcommands for the command
CLIENT:CLIENT PAUSE: Pauses processing of eitherWRITEorALLcommands until aftertimeoutmilliseconds.CLIENT REPLY: Stops server from sending replies to the client, starting; immediately ifOFF, or skips one ifSKIP. Starts sending replies ifON.