feat(config): add txn_context_enabled to allow to enable the transaction feature
#2506
Conversation
Co-authored-by: mwish <maplewish117@gmail.com>
git-hulk
changed the title
txn_context_enabled to allow to enable the transaction feature
| # At the same time, we welcome feedback on related issues to help iterative improvements. | ||
| # | ||
| # Default: no | ||
| txn-context-enabled no |
There was a problem hiding this comment.
maybe we can add some go cases for "yes" mode.
There was a problem hiding this comment.
Yeah, we need to test, but "some" may actually be almost all.
Is it possible to add a "yes" mode process to the GitHub Actions?
There was a problem hiding this comment.
You can just change the go cases to make some test functions like TestXX work on both mode, e.g.
TestXXAllMode() {
TestXX(yes)
TestXX(no)
}
Currently it is not required to include all test cases. Just some basic tests to ensure it can works.
There was a problem hiding this comment.
Okay, how about adding these tests in another PR? I need to go out recently, so I may not be able to update immediately. You can merge this PR first, and then I will create an issue to track it and solve it when I have free time.
|
Will merge this, lets' adding test in another pr. So sorry for delaying |
|
…ction feature (apache#2506) Co-authored-by: mwish <maplewish117@gmail.com>
fix: #2504