Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support COMMAND command #251

Merged
merged 6 commits into from
May 10, 2021
Merged

Support COMMAND command #251

merged 6 commits into from
May 10, 2021

Conversation

karelrooted
Copy link
Contributor

close #249

@karelrooted karelrooted marked this pull request as draft May 7, 2021 09:41
@karelrooted karelrooted force-pushed the feature/support-command-cmd branch 2 times, most recently from d72da1d to bb60cea Compare May 8, 2021 11:02
@karelrooted karelrooted marked this pull request as ready for review May 8, 2021 11:03
@karelrooted karelrooted requested review from git-hulk and ShooterIT May 8, 2021 11:03
git-hulk
git-hulk previously approved these changes May 9, 2021
View reviewed changes
src/server.cc Outdated Show resolved Hide resolved
@ShooterIT ShooterIT changed the title Support command cmd Support COMMAND command May 10, 2021
@git-hulk git-hulk self-requested a review May 10, 2021 04:57
git-hulk
git-hulk previously approved these changes May 10, 2021
View reviewed changes
@git-hulk git-hulk added the feature type new feature label May 10, 2021
@ShooterIT
Copy link
Member

LGTM, not read. Could you add some tcl tests for that

@karelrooted karelrooted force-pushed the feature/support-command-cmd branch from 6153ed1 to e9116e7 Compare May 10, 2021 06:29
@karelrooted karelrooted force-pushed the feature/support-command-cmd branch from e9116e7 to 7554832 Compare May 10, 2021 07:04
ShooterIT
ShooterIT previously approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@ShooterIT ShooterIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I supplement some things in test cases title to make them clearly

@karelrooted karelrooted merged commit e0dbdcd into apache:unstable May 10, 2021
@ShooterIT ShooterIT mentioned this pull request May 18, 2021
Merged
ShooterIT pushed a commit that referenced this pull request May 18, 2021
@karelrooted @ShooterIT
Support COMMAND command (#251)
005488f 
* Support command cmd
* Add testcase for COMMAND command
* FIX runtest return rm command's status instead of tcl test script's status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShooterIT ShooterIT ShooterIT approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
feature type new feature release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NEW] Impl the command command which compatible with Redis
3 participants
@karelrooted @ShooterIT @git-hulk