-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bitmap type DUMP/RESTORE command support #2535
feat: Bitmap type DUMP/RESTORE command support #2535
Conversation
@poipoiPIO thanks for your contribution. |
|
@poipoiPIO Thank you. |
Thank you for reviewing! |
redis::Bitmap bitmap_db(storage_, ns_); | ||
Config *config = storage_->GetConfig(); | ||
uint32_t max_btos_size = static_cast<uint32_t>(config->max_bitmap_to_string_mb) * MiB; | ||
auto s = bitmap_db.GetString(ctx, key, max_btos_size, &value); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@git-hulk would this meet the same issue like lsb to msb?
Changes requested by #2518
Summary
This PR extends dump and restore operations to provide support for bitmap-type objects using existing string object serialisation and deserialisation routines.