fix: add more check in cluster node parsing

[jonathanc-n]

references #2401

Added non confusing message when multiple nodes are added without a newline separator

[PragmaTwice]

Could you add a test case for this patch?

[jonathanc-n]

Test case is added + the node checking is more flexible

[jonathanc-n]

@PragmaTwice Are you able to see what exactly is causing the fail on the error, I don't seem to be able to see the reason for it.

[git-hulk]

@jonathanc-n #2401 is caused by missing a newline between nodes, and omitting the newline at the end should be allowed.

[jonathanc-n]

@git-hulk Alright, it should be fully working now.

[git-hulk]

@jonathanc-n You can enhance this inside parseClusterNodes

[jonathanc-n]

@PragmaTwice @git-hulk This should be good I believe, I moved the changes to cluster.cc.

[git-hulk]

@jonathanc-n It would be better to check if the field is node id in line 778?

kvrocks/src/cluster/cluster.cc

Line 778 in 2a0c57a

if (ranges.size() == 1) {

The current solution is too tricky from my perspective.

[jonathanc-n]

@git-hulk I simplified as much as I thought I could for the issue to not persist. I believe it should be fine.

[jonathanc-n]

@git-hulk @PragmaTwice Pretty sure this should be good, it passed the workflow. Unless you see some changes that should be made.

[jonathanc-n]

@git-hulk Alright, should be fine now, sorry about that.

[git-hulk]

@jonathanc-n No worry, thanks for your great contribution.

[sonarcloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
61.5% Coverage on New Code
2.0% Duplication on New Code

See analysis details on SonarCloud