-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add the ability to checkpoint an existing server, and spawn a read-only server on that view. #2548
base: unstable
Are you sure you want to change the base?
Conversation
The above check failure seems to be an unrelated i/o timeout; is there a way to rerun the checks? |
Yes, it's a flaky test and not related to this PR. |
@PragmaTwice @git-hulk could you take another look at this? It seems the previous opportunity to merge was missed because new changes made it to the unstable branch. |
Would you mind also add example for how you'd like use this? ( better on doc of cli or doc of project?) |
apologies for the linter back and forth: i'm unable to build this locally with the same set-up as the linter uses, so a lot of these issues fall through the cracks |
Quality Gate passedIssues Measures |
@mapleFU I'm not sure how to edit the docs, but one example workflow is the following. Start a read-write Kvrocks server writing data to
Say the user realizes some of the important data is incorrect: they'd like to debug their script and run it on a copy of the data, possibly changing it. They'd like to do this without fear of corrupting or changing the original server's copy of the data:
|
It would be nice to be able to spawn a read-only server on a snapshot of a given server.
This PR implements this feature, and introduces the flag
--snapshot-dir
to manage the snapshot.