Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(command): add support of RESP output format for the POLLUPDATES command #2745

Merged
merged 6 commits into from
Jan 27, 2025
Merged

feat(command): add support of RESP output format for the POLLUPDATES command #2745

merged 6 commits into from
Jan 27, 2025

Conversation

git-hulk
Copy link
Member

@git-hulk git-hulk commented Jan 27, 2025 •
edited
Loading

This PR introduces the RESP format to make it easier to debug and parse polling updates.

127.0.0.1:6666> POLLUPDATES 0 MAX 2 FORMAT RESP
1) "next_sequence"
2) (integer) 3
3) "latest_sequence"
4) (integer) 3
5) "updates"
6) 1) "default"
   2) 1) 1) "SET"
         2) "a"
         3) "1"

This closes #2712

@git-hulk
feat(command): add support of RESP output format for the POLLUPDATES …
6370adc 
…command

This PR introduces the RESP format to make it easier to debug and parse
polling updates.

```
127.0.0.1:6666> POLLUPDATES 0 MAX 2 FORMAT RESP
1) "next_sequence"
2) (integer) 3
3) "latest_sequence"
4) (integer) 3
5) "updates"
6) 1) "default"
   2) 1) 1) "SET"
         2) "a"
         3) "1"

```
@git-hulk
Merge branch 'unstable' into feature/poll-updates-by-command
87a7a08
@git-hulk @PragmaTwice
Update src/commands/cmd_server.cc
0d693be 
Co-authored-by: Twice <twice@apache.org>
PragmaTwice
PragmaTwice previously approved these changes Jan 27, 2025
View reviewed changes
@git-hulk git-hulk requested a review from PragmaTwice January 27, 2025 09:07
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
61.4% Coverage on New Code
1.5% Duplication on New Code

See analysis details on SonarQube Cloud

@PragmaTwice PragmaTwice merged commit c22f5e1 into apache:unstable Jan 27, 2025
34 checks passed
git-hulk added a commit to git-hulk/kvrocks that referenced this pull request Jan 28, 2025
@git-hulk @PragmaTwice
feat(command): add support of RESP output format for the POLLUPDATES …
c426685 
…command (apache#2745)

Co-authored-by: Twice <twice@apache.org>
Co-authored-by: Twice <twice.mliu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PragmaTwice PragmaTwice PragmaTwice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support of the RESP format for the POLLUPDATES command
2 participants
@git-hulk @PragmaTwice