Support transaction #285
Merged
Support transaction #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I2797dede68d58ea402e7da49dead7508c1226943
ShooterIT
added
major decision
ShooterIT
requested review from
git-hulk and
karelrooted
and removed request for
git-hulk
karelrooted
approved these changes
Jun 3, 2021
git-hulk
approved these changes
Jun 3, 2021
ShooterIT
added a commit
to ShooterIT/kvrocks
that referenced
this pull request
Jul 15, 2021
Kvrocks supports transaction, very simmer with Redis, we support MULTI, EXEC, DISCARD commands. But now, we don't support WATCH and UNWATCH commands.
Merged
ShooterIT
added a commit
that referenced
this pull request
Jul 19, 2021
Kvrocks supports transaction, very simmer with Redis, we support MULTI, EXEC, DISCARD commands. But now, we don't support WATCH and UNWATCH commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backgroud
As we know, redis support transaction, I prefer to call it MULTI-EXEC since it just excute multiple commands and can't be broken. But kvrocks can't support that. Especially, kvrocks doesn't support sufficient commands, we also combine many commands to impelment our logic. So MULTI-EXEC is much needed.
Implementation
If users send
MULTI, kvrocks doesn't execute commands, just queue them intomulti-cmdslist. After receivingEXEC, kvrocks will execute all queued commands.Currently, it is easy to hang up other threads by
ExclusiveGuard, so it won't be broken when we execute all commands.The same as redis, kvrocks may abort transaction when occuring errors before we queue commands.
And we also support
DISCARDto abort transaction.Disadvantage
Currently, we don't support
WATCHandUNWATCHcommands.