Make CONFIG SET command thread safe #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karelrooted
approved these changes
Jun 16, 2021
git-hulk
approved these changes
Jun 16, 2021
ShooterIT
added a commit
that referenced
this pull request
Jun 16, 2021
There may be more than one thread to change config, especially, complex config (such as std::set profiling_sample_commands), it is not thread safe, and other threads also may read wrong config, to make it easy, just use ExclusivityGuard for CONFIG SET command to avoid changing config concurrently.
ShooterIT
changed the title
ShooterIT
added a commit
to ShooterIT/kvrocks
that referenced
this pull request
Jul 15, 2021
There may be more than one thread to change config, especially, complex config (such as std::set profiling_sample_commands), it is not thread safe, and other threads also may read wrong config, to make it easy, just use ExclusivityGuard for CONFIG SET command to avoid changing config concurrently.
Merged
ShooterIT
added a commit
that referenced
this pull request
Jul 19, 2021
There may be more than one thread to change config, especially, complex config (such as std::set profiling_sample_commands), it is not thread safe, and other threads also may read wrong config, to make it easy, just use ExclusivityGuard for CONFIG SET command to avoid changing config concurrently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be more than one thread to change config, especially, complex config (such as std::set
profiling_sample_commands), it is not thread safe, and other threads also may read wrong config,to make it easy, just use ExclusivityGuard for CONFIG SET command to avoid changing config concurrently.