Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the rocksdb MultiGet in the MGet command #331

Merged
merged 4 commits into from
Jul 18, 2021
Merged

Use the rocksdb MultiGet in the MGet command #331

merged 4 commits into from
Jul 18, 2021

Conversation

git-hulk
Copy link
Member

No description provided.

@git-hulk git-hulk added the enhancement type enhancement label Jul 17, 2021
@ShooterIT
Copy link
Member

ShooterIT commented Jul 18, 2021 •
edited
Loading

It is great not to link unwind if it is not existed, i also find this problem, cool job 💯 , from this point, i want to merge this commit into 2.0.2. But in this commit, you also changed some others. so should we open another pr to resolve unwind warnings?

ShooterIT
ShooterIT reviewed Jul 18, 2021
View reviewed changes
src/redis_string.cc Show resolved Hide resolved
src/redis_string.cc Show resolved Hide resolved
src/redis_string.cc Show resolved Hide resolved
@git-hulk
Copy link
Member Author

It is great not to link unwind if it is not existed, i also find this problem, cool job 💯 , from this point, i want to merge this commit into 2.0.2. But in this commit, you also changed some others. so should we open another pr to resolve unwind warnings?

Okay, it's better to file another PR if want to merge into 2.0.2, I'll do it soon.

@git-hulk git-hulk requested a review from ShooterIT July 18, 2021 05:58
@git-hulk git-hulk merged commit 52af2b9 into apache:unstable Jul 18, 2021
ShooterIT pushed a commit to ShooterIT/kvrocks that referenced this pull request Sep 10, 2021
@git-hulk @ShooterIT
Use the rocksdb MultiGet in the MGet command (apache#331)
2cdd69d
@ShooterIT ShooterIT mentioned this pull request Sep 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShooterIT ShooterIT ShooterIT approved these changes

@karelrooted karelrooted karelrooted approved these changes

Assignees
No one assigned
Labels
enhancement type enhancement release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@git-hulk @ShooterIT @karelrooted