Supplements of guideline of compilation on macOS with make and clean up some code #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 18, 2021 17:28
LykxSassinator
changed the title
|
It's my unpleasable push of two separatable commits. The second commit is used for making several tiny improvements by converting unnecessary usages of Copy Constructor with the appropriate movement ops. |
|
cool, thanks for your contribution. Can u help to fix issues found by cpplint? |
ShooterIT
reviewed
Jul 18, 2021
As recommended, apply the suggestions from code review. Co-authored-by: Wang Yuan <wangyuancode@163.com>
Here, I reovke unnecessary and unrecommend std::move operation on the `st` object.
LykxSassinator
commented
Jul 19, 2021
ShooterIT
reviewed
Jul 19, 2021
|
cpplint error https://github.com/KvrocksLabs/kvrocks/runs/3101400846#step:4:721 please add necessary header files. |
LykxSassinator
commented
Jul 20, 2021
ShooterIT
approved these changes
Jul 20, 2021
ShooterIT
changed the title
ShooterIT
changed the title
ShooterIT
pushed a commit
to ShooterIT/kvrocks
that referenced
this pull request
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tried to compile the KVRocks on MacOS, with 11.4 Big Sur, finding that there have missed some tools for compilation on the first time. So i have make the supplements in the README.md.
Unfortunately, it seems that there still exists some limitations and errs while compiling KVRocks on MacOS by make with scripts automatically, which should be manually interfered with. Therefore, currently, it's more recommended to use cmake on MacOS or compiling it on other Linux systems.