Fix:SUBSCRIBE can't update last interaction time #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Act like redis,SUBSCRIBE must update last interaction time while a publish message received, otherwise this channel may be closed for timeout reason by default.
|
good catch @smartlee |
git-hulk
approved these changes
Jul 20, 2021
|
@Mergifyio backport 1.3 |
mergify bot
pushed a commit
that referenced
this pull request
Jul 20, 2021
Act like Redis, SUBSCRIBE must update the last interaction time while a publish message received, otherwise, this channel may be closed for timeout reasons by default. (cherry picked from commit 9a0bc14)
|
Command
|
|
@git-hulk Although there is a problem, i don't think it is right way to fix, because we just add reply to libevent buffer instead of writing to clients successfully, clients may not read anythings after sending subscribe some channels, so we never kill these clients since of timeout. This commit may plant a new bug. |
|
so Redis updates the last interaction time after writing to the client socket buffer? |
|
yep |
|
seems we didn't have a fast way to do that, any advice to workaround? |
|
Yes, there is no a easy way, maybe enable libevent write event and set appropriate water level |
|
okay |
ShooterIT
pushed a commit
to ShooterIT/kvrocks
that referenced
this pull request
Sep 10, 2021
…che#335) Act like Redis, SUBSCRIBE must update the last interaction time while a publish message received, otherwise, this channel may be closed for timeout reasons by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Act like redis,SUBSCRIBE must update last interaction time while a publish message received, otherwise this channel may be closed for timeout reason by default.