Support client kill type subcommands #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShooterIT
commented
Aug 10, 2021
ShooterIT
commented
Aug 10, 2021
ShooterIT
added
bug
ShooterIT
added a commit
that referenced
this pull request
Sep 10, 2021
Before, client subcommands must be lower cases, otherwise kvrocks will fail to execute, so sentinel still can't failover, related to #352
ShooterIT
added a commit
to ShooterIT/kvrocks
that referenced
this pull request
Sep 10, 2021
From 2.0.2, we support MULTI-EXEC, but don't support client kill type $type, so total MULTI-EXEC will be rollbacked when failing to parse unknown kill type in client command, and cause redis-sentinel fails to failover. To make it available, we should support client kill type subcommands
ShooterIT
added a commit
to ShooterIT/kvrocks
that referenced
this pull request
Sep 10, 2021
Before, client subcommands must be lower cases, otherwise kvrocks will fail to execute, so sentinel still can't failover, related to apache#352
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When redis-sentinel executes failover, it will send such commands to redis
From 2.0.2, we support MULTI-EXEC, but don't support
client kill type $type, so total MULTI-EXEC will be rollbacked when failing to parse unknownkill typein client command, and cause redis-sentinel fails to failover. To make it available, we should support client kill type subcommands