Auto set master/slave replication by cluster topology #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShooterIT
added a commit
to ShooterIT/kvrocks
that referenced
this pull request
Sep 10, 2021
Before we set cluster topology by CLUSTERX SETNODES commands, but replication relationship still need to set manually, actually, we could learn node role from cluster topology, so we will remove its master for master node, and set its master for replica node, users don't need to extra set replication relationship.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we set cluster topology by
clusterx setnodescommands, but replication relationship still need to set manually, actually, we could learn node role from cluster topology, so we will remove its master for master node, and set its master for replica node, users don't need to extra set replication relationship.