Implement CAS and CAD commands for string type #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caipengbo
requested review from
git-hulk and
ShooterIT
and removed request for
git-hulk
|
lgtm, cool job! After merging this PR, i think we should support EXAT PXAT options for SET and CAS, since these options are frequently-used and friendly, WDYT? @caipengbo @git-hulk |
Yeah, we should be as compliant with Redis commands as possible. |
ShooterIT
approved these changes
Dec 3, 2021
|
@caipengbo Could update our wiki https://github.com/KvrocksLabs/kvrocks/wiki/Support-Commands for these new commands |
|
I want to update the wiki, but I don't have permission @ShooterIT |
ShooterIT
changed the title
|
oh, let me update |
git-hulk
approved these changes
Dec 3, 2021
ShooterIT
changed the title
ShooterIT
pushed a commit
to ShooterIT/kvrocks
that referenced
this pull request
Dec 7, 2021
CAS, set its value to new value when the current value of the string corresponding to key is equal to old value. - syntax: CAS key old_value new_value [EX seconds | PX milliseconds] - return value: returns 1 if the value is successfully updated, -1 if the key does not exist, and 0 if the value fails to be updated CAD, delete the key when the value is equal to the value in the db. - syntax: CAD key value - return value: returns 1 if the value is successfully updated, -1 if the key does not exist, and 0 if the value fails to be updated More details, please see apache#415
Merged
ShooterIT
pushed a commit
that referenced
this pull request
Dec 7, 2021
CAS, set its value to new value when the current value of the string corresponding to key is equal to old value. - syntax: CAS key old_value new_value [EX seconds | PX milliseconds] - return value: returns 1 if the value is successfully updated, -1 if the key does not exist, and 0 if the value fails to be updated CAD, delete the key when the value is equal to the value in the db. - syntax: CAD key value - return value: returns 1 if the value is successfully updated, -1 if the key does not exist, and 0 if the value fails to be updated More details, please see #415
enjoy-binbin
added a commit
to enjoy-binbin/kvrocks
that referenced
this pull request
Aug 7, 2023
Since we have already implemented these options in SET / GETEX, the change is very simple. Some ref links: - CAS was added in apache#415 - SET EXAP / PXAT options was added in apache#901 - GETEX was added in apache#961
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAS
This command can be used to atomic change the value of a specified key to a new value if the current value of the key matches a specified value. The value is not changed if the current value of the key does not match the specified value.
Syntax:
Parameters:
Returned values:
CAD
This command can be used to atomic delete a specified key if the current value of the key matches a specified value. The key is not deleted if the current value of the key does not match the specified value.
Syntax:
Parameters:
Returned values: