fix:parseComplexKV with unknown metadatatype:7 #427
Conversation
kRedisSortedint metadata type 7 out of range
| @@ -54,7 +54,7 @@ Status Parser::parseSimpleKV(const Slice &ns_key, const Slice &value, int expire | |||
|
|
|||
| Status Parser::parseComplexKV(const Slice &ns_key, const Metadata &metadata) { | |||
| RedisType type = metadata.Type(); | |||
| if (type < kRedisHash || type > kRedisBitmap) { | |||
| if (type < kRedisHash || type > kRedisSortedint) { | |||
There was a problem hiding this comment.
Since Sortedint is a new addition to Kvrocks and is not supported by Redis, we don't need to deal with it here.
There was a problem hiding this comment.
@caipengbo Seems we have converted the sorted int to the Redis set type, so it should make sense here?
There was a problem hiding this comment.
a configuration should be added to support such compatiable convert?
There was a problem hiding this comment.
If it is possible, we should support to convert the sorted int to the Redis set type, we shouldn't let user to handle this problem.
There was a problem hiding this comment.
If it is possible
this also means user could read sorted int by redis commands after migrating from kvrocks to redis
There was a problem hiding this comment.
yeah, @karelrooted should have converted to the Redis set if my memory serves. Can u help to confirm? @caipengbo
There was a problem hiding this comment.
I didn't find it converted to Redis set.
|
Currently, sorted int is not converted to Redis set type. @fishery86 Are you interested in supporting this compatibility? If not, I'll support it in the future. |
ok,I will do the job |
|
resolved in #431 |
kRedisSortedint metadata type 7 out of range