Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable jemalloc when compiling #436

Merged
merged 4 commits into from
Jan 10, 2022
Merged

Allow to disable jemalloc when compiling #436

merged 4 commits into from
Jan 10, 2022

Conversation

git-hulk
Copy link
Member

No description provided.

@git-hulk git-hulk marked this pull request as draft December 26, 2021 11:17
@git-hulk git-hulk changed the title Add disable jemalloc flag Allow to disable jemalloc when compiling Dec 26, 2021
@git-hulk git-hulk marked this pull request as ready for review January 1, 2022 12:53
@git-hulk git-hulk requested a review from ShooterIT January 1, 2022 12:53
@git-hulk
Copy link
Member Author

git-hulk commented Jan 1, 2022

Allow to run the CI with jemalloc, but I think we should only run it manually labelled with run ci without jemalloc like the current PR. HDYT @ShooterIT

@ShooterIT
Copy link
Member

I think we can add this job into kvrocks.yaml since all jobs can run in parallel, this can't bring extra much time.

@git-hulk
Copy link
Member Author

git-hulk commented Jan 4, 2022

@ShooterIT We take the job into the single file since we want to run it when the PR was labelled, and other jobs should be always running.

@ShooterIT ShooterIT merged commit 3127c71 into apache:unstable Jan 10, 2022
ShooterIT pushed a commit to ShooterIT/kvrocks that referenced this pull request Jan 27, 2022
- Allow to disable the jemlloc on CMake
- Allow to disable the jemalloc on Makefile
- Add the build without jemalloc to the github actions
- Daily schedule the disable jemalloc compiling GitHub actions
ShooterIT pushed a commit to ShooterIT/kvrocks that referenced this pull request Jan 28, 2022
- Allow to disable the jemlloc on CMake
- Allow to disable the jemalloc on Makefile
- Add the build without jemalloc to the github actions
- Daily schedule the disable jemalloc compiling GitHub actions
ShooterIT pushed a commit that referenced this pull request Jan 28, 2022
- Allow to disable the jemlloc on CMake
- Allow to disable the jemalloc on Makefile
- Add the build without jemalloc to the github actions
- Daily schedule the disable jemalloc compiling GitHub actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants