Support CLUSTERX SETSLOT command #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisZMF
reviewed
Jan 19, 2022
ChrisZMF
reviewed
Jan 19, 2022
git-hulk
reviewed
Jan 19, 2022
git-hulk
approved these changes
Jan 19, 2022
ShooterIT
added a commit
to ShooterIT/kvrocks
that referenced
this pull request
Jan 27, 2022
CLUSTERX SETSLOT $slot_id NODE $node_id $new_version - Description assign the slot to the node if new version is current version+1. - Parameters $slot_id: the slot which we want to assign $node_id: the node which we want to assign the slot into NODE: keep the same with redis CLUSTER SETSLOT command, maybe we want to expand this command in the future $new_version: the new version MUST be +1 of current version so that kvrocks could execute this command, this is to guarantee this change is based on a special cluster topology - Purpose users can use this command to set slot distribution slot migration needs this command to update slot distribution New version constraint The reason why the new version MUST be +1 of current version is that, the command changes topology based on specific topology (also means specific version), we must guarantee current topology is exactly expected, otherwise this update may make topology corrupt, so base topology version is very important. This is different with CLUSTERX SETNODES commands because it uses new version topology to cover current version, it allows kvrocks nodes lost some topology updates since of network failure, it is state instead of operation.
Merged
ShooterIT
added a commit
to ShooterIT/kvrocks
that referenced
this pull request
Jan 28, 2022
CLUSTERX SETSLOT $slot_id NODE $node_id $new_version - Description assign the slot to the node if new version is current version+1. - Parameters $slot_id: the slot which we want to assign $node_id: the node which we want to assign the slot into NODE: keep the same with redis CLUSTER SETSLOT command, maybe we want to expand this command in the future $new_version: the new version MUST be +1 of current version so that kvrocks could execute this command, this is to guarantee this change is based on a special cluster topology - Purpose users can use this command to set slot distribution slot migration needs this command to update slot distribution New version constraint The reason why the new version MUST be +1 of current version is that, the command changes topology based on specific topology (also means specific version), we must guarantee current topology is exactly expected, otherwise this update may make topology corrupt, so base topology version is very important. This is different with CLUSTERX SETNODES commands because it uses new version topology to cover current version, it allows kvrocks nodes lost some topology updates since of network failure, it is state instead of operation.
ShooterIT
added a commit
that referenced
this pull request
Jan 28, 2022
CLUSTERX SETSLOT $slot_id NODE $node_id $new_version - Description assign the slot to the node if new version is current version+1. - Parameters $slot_id: the slot which we want to assign $node_id: the node which we want to assign the slot into NODE: keep the same with redis CLUSTER SETSLOT command, maybe we want to expand this command in the future $new_version: the new version MUST be +1 of current version so that kvrocks could execute this command, this is to guarantee this change is based on a special cluster topology - Purpose users can use this command to set slot distribution slot migration needs this command to update slot distribution New version constraint The reason why the new version MUST be +1 of current version is that, the command changes topology based on specific topology (also means specific version), we must guarantee current topology is exactly expected, otherwise this update may make topology corrupt, so base topology version is very important. This is different with CLUSTERX SETNODES commands because it uses new version topology to cover current version, it allows kvrocks nodes lost some topology updates since of network failure, it is state instead of operation.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command formart
CLUSTERX SETSLOT $slot_id NODE $node_id $new_version
assign the slot to the node if new version is current version+1.
Parameters
Purpose
New version constraint
The reason why the new version MUST be +1 of current version is that, the command changes topology based on specific topology (also means specific version), we must guarantee current topology is exactly expected, otherwise this update may make topology corrupt, so base topology version is very important. This is different with CLUSTERX SETNODES commands because it uses new version topology to cover current version, it allows kvrocks nodes lost some topology updates since of network failure, it is state instead of operation.