Allow to send logs to stdout/stderr #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we only supported to send logs to the log file, but we epxected to collect logs through stdout/stderr instead of the log file when deploying the Kvrocks in the container. We also upgrade the glog to v0.6.0 since the logs to stdout was supported after that.
|
This CI failure seems was related to issue: google/snappy#128, will investigate why it only happens in current PR(maybe the GCC version was updated). |
Try add |
|
cool, thanks @PragmaTwice. |
ShooterIT
approved these changes
May 29, 2022
tisonkun
approved these changes
May 29, 2022
|
Thanks @ShooterIT @tisonkun @PragmaTwice, will merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #478
Currently, we only supported sending logs to the log file,
but we expected to collect logs through stdout/stderr instead of
the log file when deploying the Kvrocks in the container. We also
upgrade the glog to v0.6.0 since logstostdout was supported after that.