Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add __builtin_unreachable to raiseError to make compiler happy #651

Merged
merged 2 commits into from
Jun 23, 2022
Merged

add __builtin_unreachable to raiseError to make compiler happy #651

merged 2 commits into from
Jun 23, 2022

Conversation

PragmaTwice
Copy link
Member

@PragmaTwice PragmaTwice commented Jun 22, 2022 •
edited
Loading

Fix this warning:

incubator-kvrocks/src/scripting.cc: In function 'int Lua::raiseError(lua_State*)':
incubator-kvrocks/src/scripting.cc:783:1: Warning: 'noreturn' function does return
  783 | }
      | ^

@tisonkun tisonkun merged commit c729935 into apache:unstable Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@ShooterIT ShooterIT ShooterIT approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PragmaTwice @git-hulk @ShooterIT @tisonkun