Fix compile warnings in kvrocks #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackwener
force-pushed
the
tsan
branch
2 times, most recently
from
730032d to
46fe25a
Compare
|
raiseError() is a little strange, it is an unreturned function. Reasonably, we should return void. But it will influent origin logic. So, I don't handle it. It's a future ticket. |
jackwener
changed the title
tisonkun
reviewed
Jun 23, 2022
There was a problem hiding this comment.
IIRC we disable TSan checker due to several problem it detected but not be resolved.
@PragmaTwice can we re-introduce TSan checker after this fix? If so, we should include the CI yaml changes into this patch.
|
I have tried four time but failed reproduce it.😂. (It may be related with OS) Env:
investigate this problem later (other PR), this PR just fix warning. |
git-hulk
reviewed
Jun 23, 2022
PragmaTwice
reviewed
Jun 23, 2022
PragmaTwice
reviewed
Jun 23, 2022
.gitignore
Outdated
Comment on lines
45
to
46
| kvrocks | ||
| kvrocks2redis |
There was a problem hiding this comment.
Suggested change
| kvrocks | |
| kvrocks2redis |
I think these files can be remove since these are in build directories.
jackwener
force-pushed
the
tsan
branch
3 times, most recently
from
21db8cf to
9174063
Compare
ShooterIT
approved these changes
Jun 24, 2022
tisonkun
approved these changes
Jun 24, 2022
|
Thanks for your contribution! Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close 639fix problem found by tsan.Thanks @PragmaTwice .
Fix warning.
Add more
gitignore(I think them also are needed by others.)