-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check sanitizer status for TCL tests in CI #698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good.
I'd like to ask whether this is a regression that we check them previously or we didn't.
.github/workflows/kvrocks.yaml
Outdated
echo $SANITIZER_OUTPUT | ||
if [[ $SANITIZER_OUTPUT ]]; then exit 1; fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to echo output in the if
block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it like if [[ $SANITIZER_OUTPUT ]]; then echo $SANITIZER_OUTPUT; exit 1; fi
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Seems there are some ASan errors in TCL tests: https://github.com/apache/incubator-kvrocks/runs/7125505577?check_suite_focus=true |
Weird since sometime these errors do not appear. |
Thanks everyone, the ASan report has been addressed in #699, and I will try to solve it later. Merging... |
Previously, TCL tests did not sense sanitizier errors when executed, and we fixed that in this PR.