Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check sanitizer status for TCL tests in CI #698

Merged
merged 3 commits into from
Jun 30, 2022

Conversation

PragmaTwice
Copy link
Member

Previously, TCL tests did not sense sanitizier errors when executed, and we fixed that in this PR.

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good.

I'd like to ask whether this is a regression that we check them previously or we didn't.

Comment on lines 151 to 152
echo $SANITIZER_OUTPUT
if [[ $SANITIZER_OUTPUT ]]; then exit 1; fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to echo output in the if block.

Copy link
Member Author

@PragmaTwice PragmaTwice Jun 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it like if [[ $SANITIZER_OUTPUT ]]; then echo $SANITIZER_OUTPUT; exit 1; fi ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@PragmaTwice
Copy link
Member Author

PragmaTwice commented Jun 30, 2022

tests/tmp/server.20197.3/stderr:==21201==ERROR: AddressSanitizer: heap-use-after-free on address 0x608000014068 at pc 0x0000006a79ef bp 0x7f33e0b7e9f0 sp 0x7f33e0b7e9e8 
tests/tmp/server.20197.3/stderr:SUMMARY: AddressSanitizer: heap-use-after-free /home/runner/work/incubator-kvrocks/incubator-kvrocks/src/redis_cmd.cc:1568:25 in Redis::CommandBPop::TryPopFromList()

Seems there are some ASan errors in TCL tests: https://github.com/apache/incubator-kvrocks/runs/7125505577?check_suite_focus=true

@PragmaTwice
Copy link
Member Author

tests/tmp/server.20197.3/stderr:==21201==ERROR: AddressSanitizer: heap-use-after-free on address 0x608000014068 at pc 0x0000006a79ef bp 0x7f33e0b7e9f0 sp 0x7f33e0b7e9e8 
tests/tmp/server.20197.3/stderr:SUMMARY: AddressSanitizer: heap-use-after-free /home/runner/work/incubator-kvrocks/incubator-kvrocks/src/redis_cmd.cc:1568:25 in Redis::CommandBPop::TryPopFromList()

Seems there are some ASan errors in TCL tests: https://github.com/apache/incubator-kvrocks/runs/7125505577?check_suite_focus=true

Weird since sometime these errors do not appear.

@PragmaTwice
Copy link
Member Author

PragmaTwice commented Jun 30, 2022

Thanks everyone, the ASan report has been addressed in #699, and I will try to solve it later. Merging...

@PragmaTwice PragmaTwice merged commit 5783f02 into apache:unstable Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants