use const & for avoiding copy #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
approved these changes
Jul 2, 2022
PragmaTwice
approved these changes
Jul 3, 2022
|
Thanks @jackwener, merging... |
mapleFU
reviewed
Jul 3, 2022
| @@ -27,7 +27,7 @@ | |||
| TEST(LockManager, LockKey) { | |||
| LockManager locks(8); | |||
| std::vector<rocksdb::Slice> keys = {"abc", "123", "456", "abc", "123"}; | |||
| for (const auto key : keys) { | |||
There was a problem hiding this comment.
I think copying slice maybe more lightweight then using reference?
There was a problem hiding this comment.
Yeah, maybe passing by value is more effective in some cases. Don't know why there are many const Slice& even in rocksdb itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace
const auto&withconst auto &just to unify format.Add
const &to avoid copy