Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace atoi to Util::DecimalStringToNum #767

Merged
merged 4 commits into from
Aug 3, 2022
Merged

Replace atoi to Util::DecimalStringToNum #767

merged 4 commits into from
Aug 3, 2022

Conversation

Ranxy
Copy link
Contributor

@Ranxy Ranxy commented Aug 3, 2022

This closes #766

PragmaTwice
PragmaTwice approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@PragmaTwice PragmaTwice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@git-hulk
Copy link
Member

git-hulk commented Aug 3, 2022

Thanks all, merging...

@git-hulk git-hulk merged commit a3a2d51 into apache:unstable Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PragmaTwice PragmaTwice PragmaTwice approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The atoi exception was not caught
3 participants
@Ranxy @git-hulk @PragmaTwice