-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace std::stol with ParseInt #897
Conversation
@PragmaTwice Thanks for your warm help. I'm just going to upload a draft to save my progress and keep doing it tomorrow. I didn't even check it myself. You have helped me. Thank you very much😆 |
@PragmaTwice Hi. The original code uses |
@PragmaTwice HI. What do you think about this. If you want to modify it in this pr, I will modify it immediately, otherwise I will modify it to another pr. |
I think it is ok to change it, since it is trivial. |
Ok, I will change it . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution!
Hi @tanruixiang, I notice there is also some code using |
OK I am willing to do this task. I think this PR information is a bit too much, we can continue to do this in the next PR. |
Thanks. Maybe there are also some |
Thanks. I will merge it soon. |
It closes #896