Add UniqueFD and ScopeExit
#973
Merged
+199
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PragmaTwice
requested review from
git-hulk,
ShooterIT,
caipengbo and
tisonkun
git-hulk
reviewed
Oct 11, 2022
PragmaTwice
commented
Oct 11, 2022
PragmaTwice
commented
Oct 11, 2022
torwig
reviewed
Oct 11, 2022
tisonkun
previously approved these changes
Oct 11, 2022
caipengbo
reviewed
Oct 12, 2022
Good idea, I will try to do this. |
caipengbo
approved these changes
Oct 12, 2022
2 tasks
tisonkun
approved these changes
Oct 12, 2022
git-hulk
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UniqueFDis a wrapped file descriptor with owership management, i.e. aunique_ptr-version fd.ScopeExitis a scope guard likestd::experimental::scope_exitin the library fundamentals v3 from WG21 orboost::scope_guardin Boost.