-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[KYUUBI-SHADED #48] Remove unused annotations for HMS client generate…
…d thrift code ### _Why are the changes needed?_ Change thrift arg `generated_annotations` from `undated` to `suppress` to remove the following annotation, to make it compilable without additional dependency for Java 11+ ``` javax.annotation.Generated(value = "Autogenerated by Thrift Compiler (0.16.0)") ``` Remove Hadoop classification annotations, it is only used for Hadoop project to generate Javadocs, useless for us. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #48 from pan3793/thrift-ann. 4781e6a [Cheng Pan] 17 ea9c8d3 [Cheng Pan] Remove unused annotations for HMS client generated thrift code Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org>
- Loading branch information
Showing
4 changed files
with
19 additions
and
47 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
...rc/gen/thrift/gen-javabean/org/apache/kyuubi/shaded/hive/metastore/api/MetaException.java
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
29 changes: 14 additions & 15 deletions
29
.../thrift/gen-javabean/org/apache/kyuubi/shaded/hive/metastore/api/ThriftHiveMetastore.java
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.