Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #6496] Step 2/2: Port ZOOKEEPER-4377 to Kyuubi shaded ZooKeeper 3.4 and 3.6 #47

Closed
wants to merge 1 commit into from

Conversation

Madhukar525722
Copy link
Contributor

@Madhukar525722 Madhukar525722 commented Jul 16, 2024

Why are the changes needed?

This is continuation of PR - #46 aims to resolve issue Kyuubi 6496.
In this PR, the zookeeper-4377 change has been backported

How was this patch tested?

This was built locally and tested in local using following steps:

  1. perform build/mvn clean package to generate kyuubi-relocated-zookeeper-parent/kyuubi-relocated-zookeeper-34/target/kyuubi-relocated-zookeeper-34-0.5.0-SNAPSHOT.jar
  2. download and install apache-kyuubi-1.9.1-bin.tgz
  3. replace KYUUBI_HOME/jars/kyuubi-relocated-zookeeper-34-0.3.0-SNAPSHOT.jar with kyuubi-relocated-zookeeper-34-0.5.0-SNAPSHOT.jar
  4. perform bin/kyuubi-zk-cli -server xxxxx:2181 to connect a Zookeeper cluster

@pan3793 pan3793 changed the title [KYUUBI #6496] Step 2/2: Port ZOOKEEPER-4377 to Kyuubi shaded ZooKeep… [KYUUBI #6496] Step 2/2: Port ZOOKEEPER-4377 to Kyuubi shaded ZooKeeper 3.4 and 3.6 Jul 16, 2024
@pan3793 pan3793 added this to the 0.4.1 milestone Jul 16, 2024
@pan3793 pan3793 closed this in b20fd14 Jul 16, 2024
pan3793 pushed a commit that referenced this pull request Jul 16, 2024
…er 3.4 and 3.6

### _Why are the changes needed?_

This is continuation of PR - #46 aims to resolve issue [Kyuubi 6496](apache/kyuubi#6496).
In this PR, the [zookeeper-4377](apache/zookeeper#1764) change has been backported

### _How was this patch tested?_

This was built locally and tested in local using following steps:

1. perform build/mvn clean package to generate kyuubi-relocated-zookeeper-parent/kyuubi-relocated-zookeeper-34/target/kyuubi-relocated-zookeeper-34-0.5.0-SNAPSHOT.jar
2. download and install [apache-kyuubi-1.9.1-bin.tgz](https://dlcdn.apache.org/kyuubi/kyuubi-1.9.1/apache-kyuubi-1.9.1-bin.tgz)
3. replace KYUUBI_HOME/jars/kyuubi-relocated-zookeeper-34-0.3.0-SNAPSHOT.jar with kyuubi-relocated-zookeeper-34-0.5.0-SNAPSHOT.jar
4. perform bin/kyuubi-zk-cli -server xxxxx:2181 to connect a Zookeeper cluster

Closes #47 from Madhukar525722/zoo-4377.

84aca7c [madlnu] [KYUUBI #6496] Step 2/2: Port ZOOKEEPER-4377 to Kyuubi shaded ZooKeeper 3.4 and 3.6

Authored-by: madlnu <madlnu@visa.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
(cherry picked from commit b20fd14)
Signed-off-by: Cheng Pan <chengpan@apache.org>
@pan3793
Copy link
Member

pan3793 commented Jul 16, 2024

Thanks, merged to master(0.5.0)/0.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants