Skip to content

Commit

Permalink
[KYUUBI #1290] Reset kinit attempt number once the command execute su…
Browse files Browse the repository at this point in the history
…ccessfully to prevent transient error accumulation

<!--
Thanks for sending a pull request!

Here are some tips for you:
  1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
  2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
  3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->

### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
  1. If you add a feature, you can talk about the use case of it.
  2. If you fix a bug, you can clarify why it is a bug.
-->
Reset attempt number after kinit successfully to prevent transient error accumulation and fail the server.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #1290 from turboFei/kinit_recover.

Closes #1290

c40c2fa [fwang12] Reset kinitMaxAttempts to 0 once the kinit command execute successfully to prevent transient error

Authored-by: fwang12 <fwang12@ebay.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
  • Loading branch information
turboFei authored and pan3793 committed Oct 25, 2021
1 parent ccb8117 commit 2675e9a
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ class KinitAuxiliaryService() extends AbstractService("KinitAuxiliaryService") {
val process = kinitProc.start()
if (process.waitFor() == 0) {
info(s"Successfully ${commands.mkString(" ")}")
kinitAttempts = 0
executor.schedule(this, kinitInterval, TimeUnit.MILLISECONDS)
} else {
if (kinitAttempts >= kinitMaxAttempts) {
Expand Down

0 comments on commit 2675e9a

Please sign in to comment.