Skip to content

Commit

Permalink
bump pnpm to v9
Browse files Browse the repository at this point in the history
  • Loading branch information
bowenliang123 committed Sep 26, 2024
1 parent ebe7e92 commit a9ea922
Show file tree
Hide file tree
Showing 4 changed files with 2,116 additions and 1,707 deletions.
12 changes: 9 additions & 3 deletions .github/workflows/style.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,15 +88,21 @@ jobs:
SPOTLESS_BLACK_VERSION=$(build/mvn help:evaluate -Dexpression=spotless.python.black.version -q -DforceStdout)
pip install black==$SPOTLESS_BLACK_VERSION
build/mvn spotless:check ${{ matrix.profiles }} -Pspotless-python
- name: Get NodeJS and PNPM version
run: |
NODEJS_VERSION=$(build/mvn help:evaluate -Dexpression=node.version -q -DforceStdout)
PNPM_VERSION=$(build/mvn help:evaluate -Dexpression=pnpm.version -q -DforceStdout)
echo "NODEJS_VERSION=${NODEJS_VERSION}" >> "$GITHUB_ENV"
echo "PNPM_VERSION=${PNPM_VERSION}" >> "$GITHUB_ENV"
- name: setup npm
uses: actions/setup-node@v4
with:
node-version: 18
node-version: ${{env.NODEJS_VERSION}}
- name: Web UI Style with node
run: |
cd ./kyuubi-server/web-ui
npm install pnpm@8 -g
pnpm install
npm install pnpm@${PNPM_VERSION} -g
pnpm install --frozen-lockfile
pnpm run lint
echo "---------------------------------------Notice------------------------------------"
echo "If this style check fail, you should follow these commands for a tentative fix"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/web-ui.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@ jobs:
run: |
cd ./kyuubi-server/web-ui
npm install pnpm@${PNPM_VERSION} -g
pnpm install
pnpm install --frozen-lockfile
pnpm run coverage
pnpm run build
Loading

0 comments on commit a9ea922

Please sign in to comment.