[KYUUBI-2450] Update lastAccessTime in getStatus and catch close laun…

…chEngineOp exception
apache · Apr 24, 2022 · cca3377 · cca3377
1 parent 3ecdd42
commit cca3377
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/kyuubi-common/src/main/scala/org/apache/kyuubi/operation/AbstractOperation.scala b/kyuubi-common/src/main/scala/org/apache/kyuubi/operation/AbstractOperation.scala
@@ -174,6 +174,7 @@ abstract class AbstractOperation(opType: OperationType, session: Session)
   override def getHandle: OperationHandle = handle
 
   override def getStatus: OperationStatus = {
+    lastAccessTime = System.currentTimeMillis()
     OperationStatus(
       state,
       createTime,

diff --git a/kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala b/kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala
@@ -155,7 +155,12 @@ class KyuubiSessionImpl(
 
   override def close(): Unit = {
     if (!OperationState.isTerminal(launchEngineOp.getStatus.state)) {
-      closeOperation(launchEngineOp.getHandle)
+      try {
+        closeOperation(launchEngineOp.getHandle)
+      } catch {
+        case e: Exception =>
+          warn(s"Error closing operation $launchEngineOp.getHandle during closing $handle for", e)
+      }
     }
     super.close()
     sessionManager.credentialsManager.removeSessionCredentialsEpoch(handle.identifier.toString)