Skip to content

Commit

Permalink
nit
Browse files Browse the repository at this point in the history
  • Loading branch information
pan3793 committed Sep 22, 2024
1 parent 8c58d2d commit e4a8d36
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions kyuubi-server/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -270,13 +270,13 @@
</dependency>

<!--
The server module does not consume the spark-sql-engine classes, but it supposes that
spark-sql-engine's jar existed on the target folder, so here we declare it as a dependency
to make sure that Maven always process spark-sql-engine module before the server module.
The server module does not consume the `spark-sql-engine` classes, but it supposes that
`spark-sql-engine`'s jar existed on the target folder, so here we declare it as a dependency
to make sure that Maven always processes `spark-sql-engine` module before the server module.
IntelliJ IDEA 2024.1 fixed the IDEA-93855, thus the relocated classes inside the
spark-sql-engine's shaded jar are visible in the server module in IDEA, for example,
`spark-sql-engine`'s shaded jar are visible in the server module in IDEA, for example,
`org.apache.kyuubi.shaded.spark.connect.proto.ExecutePlanRequest`, which silently breaks
the IDEA code analysis and jumping capabilities. This seems could be workaround by changing
the IDEA code analysis and jumping capabilities. It seems to be a workaround by changing
the dependency type from `jar`(default value) to `pom`.
-->
<dependency>
Expand Down

0 comments on commit e4a8d36

Please sign in to comment.