Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Delta lake table columns won't show up in DBeaver #1458

Closed
3 tasks done
mmuru opened this issue Nov 26, 2021 · 3 comments
Closed
3 tasks done

[Bug] Delta lake table columns won't show up in DBeaver #1458

mmuru opened this issue Nov 26, 2021 · 3 comments
Assignees

Comments

@mmuru
Copy link

mmuru commented Nov 26, 2021

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

Please, see the details in the below discussion

https://github.com/apache/incubator-kyuubi/discussions/1189

Affects Version(s)

1.3.0

Kyuubi Server Log Output

No response

Kyuubi Engine Log Output

No response

Kyuubi Server Configurations

No response

Kyuubi Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@yaooqinn
Copy link
Member

@mmuru thanks for reporting this

@pan3793 pan3793 closed this as completed in b87d206 Dec 2, 2021
pan3793 pushed a commit that referenced this issue Dec 2, 2021
<!--
Thanks for sending a pull request!

Here are some tips for you:
  1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
  2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
  3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->

### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
  1. If you add a feature, you can talk about the use case of it.
  2. If you fix a bug, you can clarify why it is a bug.
  Delta lake table columns won't show up in DBeaver client. This fix will address this issue and able to view table columns in the DBeaver now.
-->

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #1476 from mmuru/delta-table-cols-dbeaver-fix.

Closes #1458

7801c70 [Muru Muthusamy] Reformatted to fix style issue.
4126da4 [Muru Muthusamy] Updated based on review feedback and added ignore case sensitive check.
28a4a12 [Muru Muthusamy] [KYUUBI#1458] Delta lake table columns won't show up in DBeaver.

Authored-by: Muru Muthusamy <mmuthusamy@womply.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
(cherry picked from commit b87d206)
Signed-off-by: Cheng Pan <chengpan@apache.org>
@nousot-cloud-guy
Copy link
Contributor

@mmuru @yaooqinn This doesn't appear to be working for me. I had to make this change in order for table schemas to correctly show up in DBeaver. Without it, I get a "table not found" error when listing columns. Do I have a misconfiguration somewhere or is this a bug?

@mmuru
Copy link
Author

mmuru commented Jan 30, 2023 via email

nousot-cloud-guy added a commit to nousot/kyuubi that referenced this issue Feb 4, 2023
pan3793 pushed a commit that referenced this issue Feb 6, 2023
### _Why are the changes needed?_

To close #4218 .
This change ensures BI tools can list columns on Delta Lake tables in all schemas.

<img width="312" alt="image" src="https://user-images.githubusercontent.com/89149767/215793967-722eb5f9-ffe4-4ffb-b7f9-1ded06c146d7.png">

<img width="725" alt="image" src="https://user-images.githubusercontent.com/89149767/215794036-871f005f-1494-487d-90aa-1f99891177c2.png">

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [x] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #4219 from nousot-cloud-guy/feature/delta-db-schema.

Closes #4218

5698432 [Alex Wiss-Wolferding] Reversing match order in getColumnsByCatalog.
a6d973a [Alex Wiss-Wolferding] Revert "[KYUUBI #1458] Delta lake table columns won't show up in DBeaver."
20337dc [Alex Wiss-Wolferding] Revert "Using DB and table name when checking Delta table schema."
f7e4675 [Alex Wiss-Wolferding] Using DB and table name when checking Delta table schema.

Authored-by: Alex Wiss-Wolferding <alex@nousot.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
pan3793 pushed a commit that referenced this issue Feb 6, 2023
### _Why are the changes needed?_

To close #4218 .
This change ensures BI tools can list columns on Delta Lake tables in all schemas.

<img width="312" alt="image" src="https://user-images.githubusercontent.com/89149767/215793967-722eb5f9-ffe4-4ffb-b7f9-1ded06c146d7.png">

<img width="725" alt="image" src="https://user-images.githubusercontent.com/89149767/215794036-871f005f-1494-487d-90aa-1f99891177c2.png">

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [x] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #4219 from nousot-cloud-guy/feature/delta-db-schema.

Closes #4218

5698432 [Alex Wiss-Wolferding] Reversing match order in getColumnsByCatalog.
a6d973a [Alex Wiss-Wolferding] Revert "[KYUUBI #1458] Delta lake table columns won't show up in DBeaver."
20337dc [Alex Wiss-Wolferding] Revert "Using DB and table name when checking Delta table schema."
f7e4675 [Alex Wiss-Wolferding] Using DB and table name when checking Delta table schema.

Authored-by: Alex Wiss-Wolferding <alex@nousot.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
(cherry picked from commit 2b958c6)
Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants