Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Support run kyuubi-server in the foreground #312

Closed
pan3793 opened this issue Jan 28, 2021 · 1 comment
Closed

[Feature Request] Support run kyuubi-server in the foreground #312

pan3793 opened this issue Jan 28, 2021 · 1 comment
Labels
kind:feature Feature request

Comments

@pan3793
Copy link
Member

pan3793 commented Jan 28, 2021

Is your feature request related to a problem? Please describe.
Currently, we can use kyuubi start to run kyuubi-server at background, so we can't manage it's lifecycle by supervision systems like supervisord, systemd.

Describe the solution you'd like
New command kyuubi run to run kyuubi-server in frontend. It's actually what Trino (formerly PrestoSQL) does. https://trino.io/docs/current/installation/deployment.html#running-trino

Describe alternatives you've considered
N/A

Additional context
N/A
@pan3793 pan3793 changed the title [Feature Request] Support run kyuubi-server in the foreground, [Feature Request] Support run kyuubi-server in the foreground Jan 28, 2021
@yaooqinn
Copy link
Member

LGTM

@yaooqinn yaooqinn added the kind:feature Feature request label Jan 29, 2021
@pan3793 pan3793 mentioned this issue Feb 8, 2021
Closed
3 tasks
@yaooqinn yaooqinn closed this as completed Feb 8, 2021
yangrong688 pushed a commit to yangrong688/kyuubi that referenced this issue Feb 15, 2021
@pan3793 @yaooqinn
[KYUUBI apache#312] Support run kyuubi in foreground
600b014 
![pan3793](https://badgen.net/badge/Hello/pan3793/green) [![Closes apache#352](https://badgen.net/badge/Preview/Closes%20%23352/blue)](https://github.com/yaooqinn/kyuubi/pull/352) ![26](https://badgen.net/badge/%2B/26/red) ![3](https://badgen.net/badge/-/3/green) ![3](https://badgen.net/badge/commits/3/yellow) ![Feature](https://badgen.net/badge/Label/Feature/) [&#10088;?&#10089;](https://pullrequestbadge.com/?utm_medium=github&utm_source=yaooqinn&utm_campaign=badge_info)<!-- PR-BADGE: PLEASE DO NOT REMOVE THIS COMMENT -->

<!--
Thanks for sending a pull request!

Here are some tips for you:
  1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
  2. If the PR is related to an issue in https://github.com/yaooqinn/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
  3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->

### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
  1. If you add a feature, you can talk about the use case of it.
  2. If you fix a bug, you can clarify why it is a bug.
-->
close apache#312

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [x] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.readthedocs.io/en/latest/tools/testing.html#running-tests) locally before make a pull request

![image](https://user-images.githubusercontent.com/26535726/107225226-81f3cb00-6a53-11eb-8c1e-1f0d5f8275b4.png)

Closes apache#352 from pan3793/KYUUBI-312.

1a48504 [Cheng Pan] update help
08f589d [Cheng Pan] update doc and help
563f39e [Cheng Pan] [KYUUBI-312] support run kyuubi in foreground

Authored-by: Cheng Pan <379377944@qq.com>
Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:feature Feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[KYUUBI #312] Support run kyuubi in foreground pan3793/kyuubi
2 participants
@yaooqinn @pan3793