Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK][EASY] Web SQL Editor supports run SQL snippets #6248

Closed
3 tasks done
pan3793 opened this issue Apr 3, 2024 · 5 comments
Closed
3 tasks done

[TASK][EASY] Web SQL Editor supports run SQL snippets #6248

pan3793 opened this issue Apr 3, 2024 · 5 comments
Assignees
@dupen01

Comments

@pan3793
Copy link
Member

pan3793 commented Apr 3, 2024

What's the level of this task?

EASY

Code of Conduct

Search before creating

  • I have searched in the task list and found no similar tasks.

Mentor

  • I have sufficient expertise on this task, and I volunteer to be a mentor of this task to guide contributors through the task.

Skill requirements

  • Knowledge of how to run Kyuubi server
  • Basic knowledge of Vue and front-end stacks

Background and Goals

Currently, when you click the "Run" button on Kyuubi Web SQL Editor, all content in the text box will be sent to the backend service to execute.

The expected behavior is,

  • when no text is selected, send all content
  • when some text is selected, only send the selected text.
image

Implementation steps

Change code under kyuubi/server/web-ui, and do test.

Additional context

Introduction of 2024H1 Kyuubi Code Contribution Program
@silentxingtian
Copy link

Please assign this task to me, I will implement it

@pan3793
Copy link
Member Author

pan3793 commented Apr 3, 2024

@silentxingtian thanks, assigned

@pan3793
Copy link
Member Author

pan3793 commented Apr 3, 2024

After offline discussion, revoke the assignment and leave it to other contributors.

@dupen01
Copy link
Contributor

dupen01 commented Apr 7, 2024

plz assign to me

@pan3793
Copy link
Member Author

pan3793 commented Apr 7, 2024

@dupen01 thanks, assgined

@dupen01 dupen01 mentioned this issue Apr 7, 2024
Closed
4 tasks
@pan3793 pan3793 closed this as completed in 8614b2b Apr 7, 2024
pan3793 pushed a commit that referenced this issue Apr 7, 2024
@dupen01 @pan3793
[KYUUBI #6248] Web SQL Editor supports run SQL snippets
8ed1043 
# 🔍 Description
when some text is selected, only send the selected text.
## Issue References 🔗

This pull request fixes #6248

## Describe Your Solution 🔧
The Monaco Editor API is called to get the selected SQL statement, and without any other dependency.
<img width="581" alt="image" src="https://github.com/apache/kyuubi/assets/34719039/ce6ac5ae-b1fc-4778-a57e-dfda9ad51275">

## Types of changes 🔖

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6272 from dupen01/issue-6248.

Closes #6248

67d47cd [dupeng] Improved nonempty judgment
e0767bb [dupeng] Finished task "Web SQL Editor supports run SQL snippets #6248"

Authored-by: dupeng <dunett@163.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
(cherry picked from commit 8614b2b)
Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dupen01 dupen01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[KYUUBI #6248] Web SQL Editor supports run SQL snippets
3 participants
@pan3793 @dupen01 @silentxingtian