Skip to content

Refactor the log when failing to get hadoop fs delegation token #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Refactor the log when failing to get hadoop fs delegation token #2222

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
618d6e6
save
turboFei Mar 26, 2022
9b3d3e6
refactor prompt
turboFei Mar 26, 2022
3f5c61a
dedup
turboFei Mar 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions ...server/src/main/scala/org/apache/kyuubi/credentials/HadoopFsDelegationTokenProvider.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import org.apache.hadoop.hdfs.HdfsConfiguration
import org.apache.hadoop.security.{Credentials, SecurityUtil, UserGroupInformation}
import org.apache.hadoop.security.UserGroupInformation.AuthenticationMethod

import org.apache.kyuubi.Logging
import org.apache.kyuubi.{KyuubiException, Logging}
import org.apache.kyuubi.config.KyuubiConf
import org.apache.kyuubi.credentials.HadoopFsDelegationTokenProvider.{doAsProxyUser, validatedFsUris}
import org.apache.kyuubi.util.KyuubiHadoopUtils
Expand Down Expand Up @@ -63,19 +63,26 @@ class HadoopFsDelegationTokenProvider extends HadoopDelegationTokenProvider with

override def obtainDelegationTokens(owner: String, creds: Credentials): Unit = {
doAsProxyUser(owner) {
val fileSystems = fsUris.map(FileSystem.get(_, hadoopConf)).toSet
val fileSystems = fsUris.map { uri =>
FileSystem.get(uri, hadoopConf) -> uri
}.toMap

try {
// Renewer is not needed. But setting a renewer can avoid potential NPE.
val renewer = UserGroupInformation.getCurrentUser.getUserName
fileSystems.foreach { fs =>
info(s"getting token owned by $owner for: $fs")
fs.addDelegationTokens(renewer, creds)
fileSystems.foreach { case (fs, uri) =>
info(s"getting token owned by $owner for: $uri")
try {
fs.addDelegationTokens(renewer, creds)
} catch {
case e: Exception =>
throw new KyuubiException(s"Failed to get token owned by $owner for: $uri", e)
}
}
} finally {
// Token renewal interval is longer than FileSystems' underlying connections' max idle time.
// Close FileSystems won't lose efficiency.
fileSystems.foreach(_.close())
fileSystems.keys.foreach(_.close())
}
}
}
Expand Down