[KYUUBI #2227] Fix operation log dir not deleted issue #2229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulysses-you
approved these changes
Mar 27, 2022
|
thanks for the fix |
turboFei
changed the title
|
thanks for the quick review |
Codecov Report
@@ Coverage Diff @@
## master #2229 +/- ##
============================================
- Coverage 61.80% 61.80% -0.01%
Complexity 69 69
============================================
Files 331 331
Lines 16016 16018 +2
Branches 2031 2031
============================================
+ Hits 9899 9900 +1
- Misses 5295 5297 +2
+ Partials 822 821 -1
Continue to review full report at Codecov.
|
ulysses-you
pushed a commit
that referenced
this pull request
Jun 9, 2022
### _Why are the changes needed?_ Refer: #2208 (comment) To close #2227 ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #2229 from turboFei/delete_log. Closes #2227 bf7efca [Fei Wang] delete log dir with recurisive Authored-by: Fei Wang <fwang12@ebay.com> Signed-off-by: Fei Wang <fwang12@ebay.com> (cherry picked from commit 55052f9) Signed-off-by: ulysses-you <ulyssesyou@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Refer: #2208 (comment)
To close #2227
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request