[KYUUBI #2419] Release engine during closing kyuubi server session if share level is connection #2482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n during closing session
turboFei
reviewed
Apr 26, 2022
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/BatchJobSubmission.scala
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #2482 +/- ##
============================================
+ Coverage 63.46% 63.55% +0.08%
Complexity 69 69
============================================
Files 371 371
Lines 17582 17710 +128
Branches 2345 2358 +13
============================================
+ Hits 11158 11255 +97
- Misses 5392 5408 +16
- Partials 1032 1047 +15
Continue to review full report at Codecov.
|
turboFei
approved these changes
Apr 27, 2022
ulysses-you
reviewed
Apr 28, 2022
| close(!waitCompletion) | ||
| } | ||
|
|
||
| def shutdown(): Unit = { |
Contributor
There was a problem hiding this comment.
We do not need an another method, just
def close(destroyForcibly: Boolean = waitCompletion): Unit = {
ulysses-you
reviewed
Apr 28, 2022
| if (shareLevel == CONNECTION && builder != null) { | ||
| try { | ||
| builder.shutdown() | ||
| engineManager.killApplication(builder.clusterManager(), engineRefId) |
Contributor
There was a problem hiding this comment.
the ordering is a little confused: we have closed the builder, but get clusterManager from it again. It seems better:
val clusterManager = builder.clusterManager()
builder.close()
engineManager.killApplication(clusterManager)
Contributor
|
@wForget thank you for the contribution, I think the title should be refine to: |
wForget
changed the title
ulysses-you
approved these changes
Apr 28, 2022
Contributor
|
thanks, merging to master |
3 tasks
ulysses-you
added a commit
that referenced
this pull request
Feb 6, 2023
### _Why are the changes needed?_ We do not need force close engine builder and application if open session succeded. The engine itself will shutdown in connection level. This pr tries to fix regression of #2482 ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4241 from ulysses-you/skip-close. Closes #4241 0b28041 [ulysses-you] style 1636912 [ulysses-you] Only force close engine ref when open session failed Authored-by: ulysses-you <ulyssesyou18@gmail.com> Signed-off-by: ulyssesyou <ulyssesyou@apache.org>
ulysses-you
added a commit
that referenced
this pull request
Feb 6, 2023
We do not need force close engine builder and application if open session succeded. The engine itself will shutdown in connection level. This pr tries to fix regression of #2482 - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4241 from ulysses-you/skip-close. Closes #4241 0b28041 [ulysses-you] style 1636912 [ulysses-you] Only force close engine ref when open session failed Authored-by: ulysses-you <ulyssesyou18@gmail.com> Signed-off-by: ulyssesyou <ulyssesyou@apache.org> (cherry picked from commit 8760eee) Signed-off-by: ulyssesyou <ulyssesyou@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
close #2419
We need to clean up the ProcBuilder process and engine application when the session is closed.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request