Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #2478] Backport HIVE-19018 to Kyuubi Beeline #2489

Closed
wants to merge 2 commits into from

Conversation

jiaoqingbo
Copy link
Contributor

@jiaoqingbo jiaoqingbo commented Apr 27, 2022

Why are the changes needed?

fix #2478

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@jiaoqingbo
Copy link
Contributor Author

image
image
image
image
image

@yaooqinn yaooqinn added this to the v1.6.0 milestone Apr 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2022

Codecov Report

Merging #2489 (3565e58) into master (06da8cf) will decrease coverage by 0.26%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #2489      +/-   ##
============================================
- Coverage     63.76%   63.50%   -0.27%     
  Complexity       69       69              
============================================
  Files           371      371              
  Lines         17612    17703      +91     
  Branches       2348     2357       +9     
============================================
+ Hits          11231    11242      +11     
- Misses         5342     5422      +80     
  Partials       1039     1039              
Impacted Files Coverage Δ
...in/java/org/apache/hive/beeline/KyuubiBeeLine.java 0.00% <0.00%> (ø)
...ache/kyuubi/operation/KyuubiOperationManager.scala 85.24% <0.00%> (-11.06%) ⬇️
...engine/trino/operation/TrinoOperationManager.scala 82.60% <0.00%> (-3.76%) ⬇️
...la/org/apache/kyuubi/session/AbstractSession.scala 97.11% <0.00%> (-2.89%) ⬇️
...ine/flink/operation/FlinkSQLOperationManager.scala 82.92% <0.00%> (-2.08%) ⬇️
...ine/spark/operation/SparkSQLOperationManager.scala 82.22% <0.00%> (-1.87%) ⬇️
.../apache/kyuubi/client/KyuubiSyncThriftClient.scala 88.58% <0.00%> (-1.24%) ⬇️
...a/org/apache/kyuubi/jdbc/hive/KyuubiStatement.java 26.80% <0.00%> (-0.57%) ⬇️
...org/apache/kyuubi/operation/OperationManager.scala 93.75% <0.00%> (ø)
...apache/kyuubi/service/AbstractBackendService.scala 98.36% <0.00%> (+0.08%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06da8cf...3565e58. Read the comment docs.

@turboFei
Copy link
Member

thanks, merging to master and 1.5.2

@turboFei turboFei closed this in 268db01 Apr 27, 2022
turboFei pushed a commit that referenced this pull request Apr 27, 2022
### _Why are the changes needed?_

fix #2478

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [x] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #2489 from jiaoqingbo/2478.

Closes #2478

3565e58 [jiaoqingbo] invoke CI
0e127c6 [jiaoqingbo] [KYUUBI #2478] Backport HIVE-19018 to Kyuubi Beeline

Authored-by: jiaoqingbo <1178404354@qq.com>
Signed-off-by: Fei Wang <fwang12@ebay.com>
(cherry picked from commit 268db01)
Signed-off-by: Fei Wang <fwang12@ebay.com>
@turboFei turboFei modified the milestones: v1.6.0, 1.5.2 Apr 27, 2022
@pan3793 pan3793 modified the milestones: v1.6.0, 1.5.2 Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backport HIVE-19018 to Kyuubi Beeline
6 participants