-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KYUUBI #2478] Backport HIVE-19018 to Kyuubi Beeline #2489
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
approved these changes
Apr 27, 2022
yaooqinn
approved these changes
Apr 27, 2022
Codecov Report
@@ Coverage Diff @@
## master #2489 +/- ##
============================================
- Coverage 63.76% 63.50% -0.27%
Complexity 69 69
============================================
Files 371 371
Lines 17612 17703 +91
Branches 2348 2357 +9
============================================
+ Hits 11231 11242 +11
- Misses 5342 5422 +80
Partials 1039 1039
Continue to review full report at Codecov.
|
ulysses-you
approved these changes
Apr 27, 2022
thanks, merging to master and 1.5.2 |
turboFei
pushed a commit
that referenced
this pull request
Apr 27, 2022
### _Why are the changes needed?_ fix #2478 ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [x] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #2489 from jiaoqingbo/2478. Closes #2478 3565e58 [jiaoqingbo] invoke CI 0e127c6 [jiaoqingbo] [KYUUBI #2478] Backport HIVE-19018 to Kyuubi Beeline Authored-by: jiaoqingbo <1178404354@qq.com> Signed-off-by: Fei Wang <fwang12@ebay.com> (cherry picked from commit 268db01) Signed-off-by: Fei Wang <fwang12@ebay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
fix #2478
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request