Fix compatibility for spark authz with spark v3.3 #2675
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2675 +/- ##
============================================
- Coverage 64.24% 64.02% -0.23%
- Complexity 82 84 +2
============================================
Files 385 385
Lines 18673 18737 +64
Branches 2531 2549 +18
============================================
- Hits 11997 11996 -1
- Misses 5532 5576 +44
- Partials 1144 1165 +21
Continue to review full report at Codecov.
|
| case "ShowFunctionsCommand" => | ||
| getPlanField[Option[String]]("db").foreach { db => | ||
| inputObjs += databasePrivileges(db) | ||
| } |
There was a problem hiding this comment.
why we need this change
There was a problem hiding this comment.
using filtered command instead of this
There was a problem hiding this comment.
I see it is not for compatibility but for clean up
|
Since the spark-3.3 support is in progress, I have run a GA job on my forked repo. see cfmcgrady#16 |
CI passed! |
|
thanks @cfmcgrady for checking |
|
Thanks, merging to master |
7 participants
Why are the changes needed?
Some of the commands were migrated to v2 in spark v3.3, this PR is used to match them
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request