-
Notifications
You must be signed in to change notification settings - Fork 982
Test Spark 3.3.0-rc3 #2735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Spark 3.3.0-rc3 #2735
Conversation
|
apache/spark#36591 causes the failure of unit tests. |
| // see https://issues.apache.org/jira/browse/SPARK-39214 | ||
| // Improve errors related to CAST | ||
| """to int causes overflow, | ||
| |to "INT" causes overflow, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this error message to "INT" causes overflow anymore, the behavior of uppercasing SQL types in error messages is something that happened after Spark-3.3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I simplify to just check "overflow"
Codecov Report
@@ Coverage Diff @@
## master #2735 +/- ##
============================================
- Coverage 61.79% 61.78% -0.02%
Complexity 273 273
============================================
Files 411 411
Lines 19826 19826
Branches 2703 2703
============================================
- Hits 12252 12249 -3
Misses 6378 6378
- Partials 1196 1199 +3
Continue to review full report at Codecov.
|
|
Thanks, merging to master |
Why are the changes needed?
https://www.mail-archive.com/dev@spark.apache.org/msg29048.html
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request