Skip to content

Conversation

@pan3793
Copy link
Member

@pan3793 pan3793 commented May 25, 2022

Why are the changes needed?

https://www.mail-archive.com/dev@spark.apache.org/msg29048.html

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@github-actions github-actions bot added kind:build kind:infra license, community building, project builds, asf infra related, etc. labels May 25, 2022
@cfmcgrady
Copy link
Contributor

cfmcgrady commented May 25, 2022

apache/spark#36591 causes the failure of unit tests.

// see https://issues.apache.org/jira/browse/SPARK-39214
// Improve errors related to CAST
"""to int causes overflow,
|to "INT" causes overflow,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this error message to "INT" causes overflow anymore, the behavior of uppercasing SQL types in error messages is something that happened after Spark-3.3.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simplify to just check "overflow"

@codecov-commenter
Copy link

Codecov Report

Merging #2735 (b1bad7e) into master (c84ea87) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head b1bad7e differs from pull request most recent head 99ea2b5. Consider uploading reports for the commit 99ea2b5 to get more accurate results

@@             Coverage Diff              @@
##             master    #2735      +/-   ##
============================================
- Coverage     61.79%   61.78%   -0.02%     
  Complexity      273      273              
============================================
  Files           411      411              
  Lines         19826    19826              
  Branches       2703     2703              
============================================
- Hits          12252    12249       -3     
  Misses         6378     6378              
- Partials       1196     1199       +3     
Impacted Files Coverage Δ
...ache/kyuubi/operation/KyuubiOperationManager.scala 83.60% <0.00%> (-1.64%) ⬇️
...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala 84.27% <0.00%> (-0.63%) ⬇️
...in/scala/org/apache/kyuubi/config/KyuubiConf.scala 96.64% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c84ea87...99ea2b5. Read the comment docs.

@pan3793 pan3793 requested a review from cfmcgrady May 26, 2022 01:25
@pan3793 pan3793 self-assigned this May 26, 2022
@pan3793 pan3793 added this to the v1.6.0 milestone May 26, 2022
@pan3793
Copy link
Member Author

pan3793 commented May 26, 2022

Thanks, merging to master

@pan3793 pan3793 closed this in e9797c0 May 26, 2022
@pan3793 pan3793 mentioned this pull request May 26, 2022
3 tasks
@pan3793 pan3793 deleted the spark-33-rc3 branch May 26, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:build kind:infra license, community building, project builds, asf infra related, etc. module:spark

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants