[KYUUBI #2960] TFrontendService.SERVER_VERSION shall be HIVE_CLI_SERVICE_PROTOCOL_V11 #2961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind:build
kind:documentation
pan3793
changed the title
pan3793
removed
module:kubernetes
kind:documentation
cxzl25
approved these changes
Jun 29, 2022
Codecov Report
@@ Coverage Diff @@
## branch-1.5 #2961 +/- ##
================================================
- Coverage 61.18% 61.17% -0.02%
Complexity 69 69
================================================
Files 302 302
Lines 15095 15095
Branches 1952 1952
================================================
- Hits 9236 9234 -2
Misses 5080 5080
- Partials 779 781 +2
Continue to review full report at Codecov.
|
…I_SERVICE_PROTOCOL_V11
yaooqinn
reviewed
Jun 29, 2022
| @@ -623,7 +623,7 @@ private[kyuubi] object TFrontendService { | |||
|
|
|||
| final val CURRENT_SERVER_CONTEXT = new ThreadLocal[FeServiceServerContext]() | |||
|
|
|||
| final val SERVER_VERSION = TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V10 | |||
| final val SERVER_VERSION = TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V11 | |||
There was a problem hiding this comment.
let's use TProtocolVersion.values.max once and for all
yaooqinn
approved these changes
Jun 29, 2022
turboFei
approved these changes
Jun 29, 2022
turboFei
pushed a commit
that referenced
this pull request
Jun 29, 2022
…ICE_PROTOCOL_V11 ### _Why are the changes needed?_ 1. bugfix for issue #2960 ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #2961 from CavemanIV/kyuubi-2960. Closes #2960 8aa38eb [zhangliang] TFrontendService always use newest hive cli TProtocolVersion 25e5110 [zhangliang] [KYUUBI #2960] TFrontendService.SERVER_VERSION shall be HIVE_CLI_SERVICE_PROTOCOL_V11 Authored-by: zhangliang <zhangliang@trip.com> Signed-off-by: Fei Wang <fwang12@ebay.com> (cherry picked from commit cf27278) Signed-off-by: Fei Wang <fwang12@ebay.com>
|
thanks, merged to branch-1.5 and master |
|
Hi @CavemanIV could you bind the email(zhangliang@trip.com) with your github account? Now your account is not bound.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request