[KYUUBI #2478][FOLLOWUP] Fix bin/beeline without -u exits unexpectedly #3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @yaooqinn |
turboFei
reviewed
Jul 9, 2022
turboFei
changed the title
turboFei
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3031 +/- ##
============================================
- Coverage 50.45% 50.43% -0.02%
Complexity 6 6
============================================
Files 454 454
Lines 25462 25462
Branches 3575 3575
============================================
- Hits 12846 12843 -3
- Misses 11393 11394 +1
- Partials 1223 1225 +2
Continue to review full report at Codecov.
|
|
thanks, merged to master |
turboFei
pushed a commit
that referenced
this pull request
Jul 9, 2022
### _Why are the changes needed?_ fix #3030 ### _How was this patch tested?_ - [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [x] Add screenshots for manual tests if appropriate  - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #3031 from jiaoqingbo/kyuubi-3030. Closes #2478 58ba011 [jiaoqingbo] change junit location a4130da [jiaoqingbo] add license 9ff1366 [jiaoqingbo] [KYUUBI #3030] fix bin/beeline without -u exits unexpectedly Authored-by: jiaoqingbo <1178404354@qq.com> Signed-off-by: Fei Wang <fwang12@ebay.com>
|
also backport to branch 1.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
fix #3030
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request