Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #3060] [Subtask][#3059] Build content of the connector document section #3061

Closed
wants to merge 1 commit into from

Conversation

yaooqinn
Copy link
Member

@yaooqinn yaooqinn commented Jul 13, 2022

Why are the changes needed?

Build content of the connector document section

Main changes proposed in this PR

  • the integration section is renamed to connector and lifted up
  • connectors are separated by engines
  • the usage guide is broken into 2 section: Admin Guide and User Guide

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

image

  • Run test locally before make a pull request

@yaooqinn yaooqinn added this to the v1.6.0 milestone Jul 13, 2022
@yaooqinn yaooqinn self-assigned this Jul 13, 2022
@github-actions github-actions bot added the kind:documentation Documentation is a feature! label Jul 13, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3061 (6932cbb) into master (32970ce) will increase coverage by 0.94%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3061      +/-   ##
============================================
+ Coverage     50.56%   51.50%   +0.94%     
  Complexity        6        6              
============================================
  Files           455      453       -2     
  Lines         25631    25167     -464     
  Branches       3589     3506      -83     
============================================
+ Hits          12960    12962       +2     
+ Misses        11435    10965     -470     
- Partials       1236     1240       +4     
Impacted Files Coverage Δ
...ache/kyuubi/operation/KyuubiOperationManager.scala 80.82% <0.00%> (-1.37%) ⬇️
...g/apache/kyuubi/server/KinitAuxiliaryService.scala 65.78% <0.00%> (-0.88%) ⬇️
...he/kyuubi/jdbc/hive/ZooKeeperHiveClientHelper.java 2.88% <0.00%> (-0.76%) ⬇️
...yuubi/server/metadata/jdbc/JDBCMetadataStore.scala 89.27% <0.00%> (-0.70%) ⬇️
...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala 83.12% <0.00%> (-0.63%) ⬇️
...in/scala/org/apache/kyuubi/config/KyuubiConf.scala 97.25% <0.00%> (-0.08%) ⬇️
...in/java/org/apache/kyuubi/jdbc/hive/JdbcTable.java 0.00% <0.00%> (ø)
...n/java/org/apache/kyuubi/jdbc/hive/JdbcColumn.java 0.00% <0.00%> (ø)
...java/org/apache/kyuubi/jdbc/hive/auth/SaslQOP.java 0.00% <0.00%> (ø)
...ava/org/apache/kyuubi/jdbc/hive/cli/FetchType.java 0.00% <0.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32970ce...6932cbb. Read the comment docs.

@yaooqinn yaooqinn closed this in 4864762 Jul 14, 2022
@yaooqinn
Copy link
Member Author

thanks, merged to master

@yaooqinn yaooqinn deleted the 3060 branch July 14, 2022 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:documentation Documentation is a feature!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants