Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Subtask] Connectors for Spark SQL Query Engine -> TPC-DS #3228

Closed
wants to merge 1 commit into from

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Aug 14, 2022

Why are the changes needed?

Document Kyuubi Spark TPC-DS connector

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate
    image

  • Run test locally before make a pull request

@pan3793 pan3793 marked this pull request as ready for review August 14, 2022 02:20
@github-actions github-actions bot added the kind:documentation Documentation is a feature! label Aug 14, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3228 (0cafdf8) into master (e847ab3) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3228      +/-   ##
============================================
- Coverage     51.68%   51.63%   -0.06%     
  Complexity        6        6              
============================================
  Files           464      464              
  Lines         25651    25651              
  Branches       3551     3551              
============================================
- Hits          13259    13245      -14     
- Misses        11133    11138       +5     
- Partials       1259     1268       +9     
Impacted Files Coverage Δ
.../kyuubi/server/mysql/constant/MySQLErrorCode.scala 13.84% <0.00%> (-6.16%) ⬇️
...ache/kyuubi/server/mysql/MySQLCommandHandler.scala 76.13% <0.00%> (-3.41%) ⬇️
...ache/kyuubi/server/mysql/MySQLGenericPackets.scala 76.59% <0.00%> (-2.13%) ⬇️
...ache/kyuubi/operation/KyuubiOperationManager.scala 80.82% <0.00%> (-1.37%) ⬇️
...mon/src/main/scala/org/apache/kyuubi/Logging.scala 43.42% <0.00%> (-1.32%) ⬇️
...ain/scala/org/apache/kyuubi/engine/EngineRef.scala 74.07% <0.00%> (-0.93%) ⬇️
...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala 82.60% <0.00%> (-0.63%) ⬇️
...a/org/apache/kyuubi/service/TFrontendService.scala 91.17% <0.00%> (-0.30%) ⬇️
...in/scala/org/apache/kyuubi/config/KyuubiConf.scala 97.27% <0.00%> (-0.09%) ⬇️
...g/apache/kyuubi/operation/BatchJobSubmission.scala 74.40% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pan3793 pan3793 requested review from cxzl25 and wForget August 15, 2022 07:39
@pan3793 pan3793 self-assigned this Aug 15, 2022
@pan3793 pan3793 added this to the v1.6.0 milestone Aug 15, 2022
@pan3793
Copy link
Member Author

pan3793 commented Aug 15, 2022

Thanks, merging to master

@pan3793 pan3793 closed this in 5ed671c Aug 15, 2022
@pan3793 pan3793 deleted the tpcds-doc branch August 15, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:documentation Documentation is a feature!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants