Bump Netty from 4.1.73.Final to 4.1.84.Final #3796
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfmcgrady
approved these changes
Nov 10, 2022
Member
Author
|
Thanks, merging to master |
github-actions
bot
added
the
kind:infra
Member
Author
|
cherry picked to branch-1.6 as it is required for #3776 |
pan3793
added a commit
that referenced
this pull request
Dec 2, 2022
### _Why are the changes needed?_ Bump Netty to latest version. netty/netty#12146 explained that netty-tcnative-classes should be optional, otherwise will cause netty/netty#12101 ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #3796 from pan3793/netty. Closes #3796 2b29923 [Cheng Pan] license 447a8d0 [Cheng Pan] nit 62abe48 [Cheng Pan] nit 506f76b [Cheng Pan] Bump Netty from 4.1.73.Final to 4.1.84.Final Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Bump Netty to latest version.
netty/netty#12146 explained that netty-tcnative-classes should be optional, otherwise will cause netty/netty#12101
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request