-
Notifications
You must be signed in to change notification settings - Fork 972
Helm chart improvements #3976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm chart improvements #3976
Conversation
…ndant $KYUUBI_HOME variable set
…xt support to helm chart
|
@dnskr thanks for your effort, it's awesome to make the commit history so clear, but if we directly merge it(our merge tool forcibly uses squash), commit history will be lost, would you mind opening PR one by one? |
|
cc @hddong |
|
thanks, merging to master |
@pan3793 I created several commits just to make review process easier. Squashed commit contains all commit messages, so looks good for me. For next PRs I'll do it more granular (one change per PR). |
|
Thanks @dnskr |
Why are the changes needed?
The changes are needed to improve helm chart usability.
The PR introduces a few enhancements (one per commit) to make Kyuubi helm chart more friendly to be used.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request