Skip to content

Conversation

@dnskr
Copy link
Contributor

@dnskr dnskr commented Dec 13, 2022

Why are the changes needed?

The changes are needed to improve helm chart usability.
The PR introduces a few enhancements (one per commit) to make Kyuubi helm chart more friendly to be used.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@pan3793
Copy link
Member

pan3793 commented Dec 14, 2022

@dnskr thanks for your effort, it's awesome to make the commit history so clear, but if we directly merge it(our merge tool forcibly uses squash), commit history will be lost, would you mind opening PR one by one?

@ulysses-you
Copy link
Contributor

cc @hddong

@ulysses-you
Copy link
Contributor

thanks, merging to master

@ulysses-you ulysses-you added this to the v1.7.0 milestone Dec 14, 2022
@dnskr
Copy link
Contributor Author

dnskr commented Dec 14, 2022

@dnskr thanks for your effort, it's awesome to make the commit history so clear, but if we directly merge it(our merge tool forcibly uses squash), commit history will be lost, would you mind opening PR one by one?

@pan3793 I created several commits just to make review process easier. Squashed commit contains all commit messages, so looks good for me. For next PRs I'll do it more granular (one change per PR).

@pan3793
Copy link
Member

pan3793 commented Dec 14, 2022

Thanks @dnskr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants