Skip to content

Conversation

@dnskr
Copy link
Contributor

@dnskr dnskr commented Dec 14, 2022

Why are the changes needed?

The changes are needed to be compliant with official Kubernetes and Helm recommendations:

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@codecov-commenter
Copy link

Codecov Report

Merging #3980 (937da0e) into master (0295c0f) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3980      +/-   ##
============================================
- Coverage     51.95%   51.90%   -0.06%     
  Complexity       13       13              
============================================
  Files           522      522              
  Lines         29042    29042              
  Branches       3887     3887              
============================================
- Hits          15089    15074      -15     
- Misses        12577    12587      +10     
- Partials       1376     1381       +5     
Impacted Files Coverage Δ
.../kyuubi/server/mysql/constant/MySQLErrorCode.scala 13.84% <0.00%> (-6.16%) ⬇️
...ache/kyuubi/server/mysql/MySQLCommandHandler.scala 77.77% <0.00%> (-4.05%) ⬇️
...ache/kyuubi/operation/KyuubiOperationManager.scala 79.45% <0.00%> (-2.74%) ⬇️
...ache/kyuubi/server/mysql/MySQLGenericPackets.scala 76.59% <0.00%> (-2.13%) ⬇️
...g/apache/kyuubi/operation/BatchJobSubmission.scala 75.47% <0.00%> (-1.26%) ⬇️
...g/apache/kyuubi/session/KyuubiSessionManager.scala 94.02% <0.00%> (-0.75%) ⬇️
...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala 80.74% <0.00%> (-0.63%) ⬇️
...apache/kyuubi/engine/JpsApplicationOperation.scala 77.41% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pan3793 pan3793 added this to the v1.7.0 milestone Dec 15, 2022
@pan3793
Copy link
Member

pan3793 commented Dec 15, 2022

Thanks, merging to master

@pan3793 pan3793 closed this in ff6b792 Dec 15, 2022
@dnskr dnskr deleted the helm_recommended_labels branch May 11, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants